Support UR types and arbitrary wallet vendors #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 16, 2021 17:15
- Add support for reading Blockchain Commons UR types - Add support for reading in Blue Wallet’s multsig file format - Display and print multisig and PSBT QRs using the same encoding they were received in - Add QRPartParser for handling parsing arbitrary QR encodings - Rename MultisigPolicy to MultisigWallet - Print out UR-BIP39 passphrases by default and add support for reading them in - Show xpubs as a single QR with no encoding to support the widest range of wallets - Always animate UR QR codes since they are fountain encoded
ghost
merged commit 
ghost
mentioned this pull request
3 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the https://github.com/jreesun/urtypes library I just released which is essentially a Python port of the KeystoneHQ ur-registry with some tweaks to support parsing Blockchain Commons UR types.
It also refactors some of the QR parsing logic and now encodes the multisig wallet and PSBT QRs in the format they were read in, so that, in theory, Krux should support arbitrary wallet vendors by mirroring back to them data in a format they understand.
Tested with Specter Desktop (for regressions), Blue Wallet, and Sparrow Wallet, and all three vendors' QR codes are able to be received/sent, with the exception of Sparrow which seems to be ignoring Krux's signed PSBT despite (seemingly) parsing it correctly per debug logs. I am investigating this further and will add a separate PR to fix any issues there.