Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update references to 2019 #904

Merged
merged 4 commits into from
Jan 3, 2019
Merged

update references to 2019 #904

merged 4 commits into from
Jan 3, 2019

Conversation

rovolution
Copy link
Collaborator

happy new year! 🎉

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • documentation updates to README file
  • examples within /tpl/index.tpl (for new options being added)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

@seiyria
Copy link
Owner

seiyria commented Jan 3, 2019

👌

@seiyria
Copy link
Owner

seiyria commented Jan 3, 2019

Looks good to me! We can merge this if it covers all the files (it looks like it does).

@rovolution rovolution merged commit dd5afbc into master Jan 3, 2019
@rovolution rovolution deleted the 2019 branch January 3, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rovolution @seiyria