Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix mouseup trigger change #900

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Bugfix mouseup trigger change #900

merged 2 commits into from
Dec 21, 2018

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Dec 20, 2018

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • documentation updates to README file
  • examples within /tpl/index.tpl (for new options being added)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

This fixes #896

Copy link
Collaborator

@jespirit jespirit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to make that one change and everything else looks good.

Great work by the way, you can tell that a person understands the source code well when they can write unit tests

@viceice
Copy link
Contributor Author

viceice commented Dec 21, 2018

I only needed 5 min to fix the code, but i spend 3 hours to make a good test. 😝

@jespirit
Copy link
Collaborator

I only needed 5 min to fix the code, but i spend 3 hours to make a good test.

Haha, I know exactly what you mean.

Great work, will be merging soon.

@jespirit jespirit merged commit a5fc012 into seiyria:master Dec 21, 2018
@viceice viceice deleted the bugfix/896-mouseup-trigger-change branch December 21, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mouseup does not trigger change event
3 participants