Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace handling #893

Merged
merged 7 commits into from
Dec 18, 2018
Merged

Conversation

jespirit
Copy link
Collaborator

@jespirit jespirit commented Dec 13, 2018

I noticed these two lines were incorrect. The slider instance that is added/removed should be based on the namespace, either: slider or bootstrapSlider.

this.$element.removeData('slider');

$.data(this.element, 'slider', this);

I added unit tests.

I also fixed some unit tests that were not properly destroying the <div> slider element. This caused some unit tests to fail when it used .siblings() to check the <div> slider element, but the method also collects more than 1 <div> if they exist, which was causing hard to track bugs.

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

Copy link
Collaborator

@rovolution rovolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jespirit jespirit merged commit 84f8f4c into seiyria:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants