Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these two lines were incorrect. The slider instance that is added/removed should be based on the namespace, either: slider or bootstrapSlider.
bootstrap-slider/src/js/bootstrap-slider.js
Line 995 in 88dfe2a
bootstrap-slider/src/js/bootstrap-slider.js
Line 1064 in 88dfe2a
I added unit tests.
I also fixed some unit tests that were not properly destroying the
<div>
slider element. This caused some unit tests to fail when it used.siblings()
to check the<div>
slider element, but the method also collects more than 1<div>
if they exist, which was causing hard to track bugs.Pull Requests
Please accompany all pull requests with the following (where appropriate):
grunt test
in your Terminal within the bootstrap-slider repository directory