switched to using variables for the colors #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rovolution
approved these changes
Sep 23, 2017
|
@jmarikle changes merged and published to v9.9.0 Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Referencing #778
Requesting pull for branch that uses variables in place of hardcoded values for the control colors. Additionally, brand-primary is used. bootstrap variables file is already a dependency of bootstrap-slider.less by use of
@line-height-computedin variables.less, so that just uses the@brand-primaryvariable. For the SASS file, it either uses the$brand-primaryvariable if it exists or it uses a default of#0480be.Feel free to tweak the colors as needed. Otherwise, if they need adjusted, I can make the changes in another commit too.