Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support types from files outside of cwd #98

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

adrienharnay
Copy link
Contributor

Currently, types aren't captured for this config:

const playroomConfig = {
  cwd: path.resolve('../my-design-system'),
};

This architecture being common in a monorepo, this little change does the trick.

@markdalgleish
Copy link
Member

I can't find this absolute option in find-up or any of its dependencies. What exactly is this option doing? From what I can see, find-up was already returning an absolute path.

@adrienharnay
Copy link
Contributor Author

And of course I made the wrong change... it is good now :)

Reference: https://github.com/mrmlnc/fast-glob#absolute

@markdalgleish markdalgleish changed the title Support types from files outside of playroom's cwd fix: Support types from files outside of cwd Dec 10, 2019
@markdalgleish markdalgleish merged commit 02d5f01 into seek-oss:master Dec 10, 2019
@markdalgleish
Copy link
Member

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants