feat: Make code editor resizable and detachable #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks so good! 👏🏻😍 It'd be cool to use an icon for the undock action. The icon Chrome DevTools uses is pretty good: |
markdalgleish
changed the title
The previous implementation meant that any events (i.e onClicks) weren't being surfaced to the main application window
package.json
Outdated
| @@ -83,8 +84,10 @@ | |||
| "webpack-merge": "^4.1.4" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/plugin-transform-react-constant-elements": "^7.0.0", | |||
There was a problem hiding this comment.
Does this dependency still need to be here?
There was a problem hiding this comment.
@svgr/webpack lists it as an internal dependancy but without manually adding it I'm getting Error: Cannot find module '@babel/plugin-transform-react-constant-elements' . I'll look into it
markdalgleish
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements both a resizable editor, and a detachable editor.
The resizing is implemented using
re-resizableand the detachable editor is implemented with react portals. See here for external window/portal inspiration.Demo:
https://cl.ly/909106ad4a23
Limitations:
The new window needs to be focussed by the user before the code renders.
The window.open gets blocked by the browser, not sure if there are approaches here to avoid this.
Basic testing in latest Chrome/Safari/FF