Test staking module wrapper and ABCI++ batch signing #515
+937
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
approved these changes
Mar 4, 2025
| @@ -32,6 +32,7 @@ require ( | |||
| github.com/cosmos/ibc-go/v8 v8.4.0 | |||
| github.com/cosmos/rosetta v0.0.0-00010101000000-000000000000 | |||
| github.com/ethereum/go-ethereum v1.14.13 | |||
| github.com/golang/mock v1.6.0 | |||
There was a problem hiding this comment.
Should we not be using the gomock fork maintained by Uber?
Update, June 2023: This repo and tool are no longer maintained. Please see go.uber.org/mock for a maintained fork instead.
There was a problem hiding this comment.
I had to add this to control SDK's mocks :/
| mockBatchNumber: 100, | ||
| isNewValidator: []bool{false, false, true}, | ||
| }, | ||
| // TODO Reactivate |
There was a problem hiding this comment.
Maybe we can make a note in an issue or in the PR for this so we don't forget?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for important components that were missing comprehensive testing.