Add convert_luau_numbers rule
#257
Open
+148
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeparlefrancais
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Hi! Thanks for submitting the PR
Before merging this, I'd like to see these:
- change the rule name to
convert_luau_numbers - convert only binary numbers to decimal numbers because those are the compatibility issue
- for each kind of number, if they have a token, remove the token if it contains any underscores (
_)
src/rules/mod.rs
Outdated
| @@ -235,6 +237,7 @@ pub fn get_default_rules() -> Vec<Box<dyn Rule>> { | |||
| Box::<RemoveNilDeclaration>::default(), | |||
| Box::<RenameVariables>::default(), | |||
| Box::<RemoveFunctionCallParens>::default(), | |||
| Box::<RemoveNumberLiterals>::default(), | |||
There was a problem hiding this comment.
I think I would not put this rule in the default rules, at least for now
src/rules/remove_number_literals.rs
Outdated
| struct Processor {} | ||
|
|
||
| impl NodeProcessor for Processor { | ||
| fn process_expression(&mut self, exp: &mut Expression) { |
There was a problem hiding this comment.
There is a function for number expressions you can use directly:
Suggested change
| fn process_expression(&mut self, exp: &mut Expression) { | |
| fn process_number_expression(&mut self, number: &mut NumberExpression) { |
|
I can't see a reason why you would want this, but it might be cool to atleast have an option for it to convert all number literals (so even hex literals like 0xFFFFFFF, like it's doing right now), instead of it only converting binary literals and removing underscores. |
… changed to convert_luau_numbers and only converts binary to decimal and removes underscores from token)
jeparlefrancais
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256
Changes
convert_luau_numbersthat converts luau's number literal syntax.convert_luau_numbers.