Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Docker setup #182

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

julienrf
Copy link
Collaborator

While working on the blog article I noticed that many lines were unused.

I also figured out how to fix the links between the master and worker nodes.

While working on the blog article I noticed that many lines were unused.

I also figured out how to fix the links between the master and worker nodes.
@julienrf julienrf requested a review from tarzanek July 23, 2024 12:47
@tarzanek
Copy link
Contributor

I was hoping to have network isolation, so now everything is host network?

@tarzanek
Copy link
Contributor

okay, so if we are going to merge it
we need to make sure docker is used only for demos

let's put

This approach is useful if you do not need a high-level of performance, and want to quickly try out the Migrator without having to set up a real cluster of nodes. It requires Docker and Git.

into a caution or note section

@julienrf
Copy link
Collaborator Author

julienrf commented Jul 31, 2024

Done in c2835e5.

@tarzanek tarzanek merged commit 11926be into scylladb:master Jul 31, 2024
2 checks passed
@julienrf julienrf deleted the improve-docker branch July 31, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants