Skip to content

[Backport 2025.1] fix(nemesis): TTL setter workaround added for non TWCS tables #10553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

scylladbbot
Copy link

This commit should fix unexpected python error:

Traceback (most recent call last):
  File "/home/ubuntu/scylla-cluster-tests/sdcm/nemesis.py", line 5559, in wrapper
    result = method(*args[1:], **kwargs)
  File "/home/ubuntu/scylla-cluster-tests/sdcm/nemesis.py", line 3027, in disrupt_modify_table
    disrupt_func()
  File "/home/ubuntu/scylla-cluster-tests/sdcm/nemesis.py", line 2839, in modify_table_default_time_to_live
    ttl_to_set = calculate_allowed_twcs_ttl(compaction_properties, default_min_ttl, default_max_ttl)
UnboundLocalError: local variable 'compaction_properties' referenced before assignment

Testing

https://argus.scylladb.com/tests/scylla-cluster-tests/24ba3271-f770-4512-b72f-e09888871140

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)

  • Add unit tests to cover my changes (under unit-test/ folder)

  • Update the Readme/doc folder relevant to this change (if needed)

  • (cherry picked from commit e2464d2)

Parent PR: #10336

for avoiding error: UnboundLocalError: local variable
 'compaction_properties' referenced before assignment

(cherry picked from commit e2464d2)
@scylladbbot
Copy link
Author

@timtimb0t - This PR has conflicts, therefore it was moved to draft
Please resolve them and mark this PR as ready for review

@vponomaryov vponomaryov closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants