Runner Reconnect: Connection Process Revamp #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patuwwy
force-pushed
the
feat/reconnect
branch
from
8bb8451 to
a542209
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
4 times, most recently
from
e233b91 to
7526211
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
3 times, most recently
from
94d5e34 to
156ab2b
Compare
piotrek6641
force-pushed
the
feat/reconnect
branch
from
156ab2b to
c390605
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
from
c390605 to
707830e
Compare
ErykSolecki
previously requested changes
Jan 23, 2024
patuwwy
force-pushed
the
feat/reconnect
branch
3 times, most recently
from
f42bf73 to
e2eec2e
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
from
e2eec2e to
10be6f2
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
from
a205440 to
0afc685
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
from
78f77eb to
17b1ee5
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
2 times, most recently
from
58638d1 to
7a23488
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
from
7a23488 to
1895e1a
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
from
7edebd9 to
e341423
Compare
patuwwy
force-pushed
the
feat/reconnect
branch
from
d7707d3 to
a05c64f
Compare
a-tylenda
approved these changes
Mar 6, 2024
alicja-gruzdz
dismissed
ErykSolecki’s stale review
The requested changes were introduced, but the request is still blocking the merge. @eryk is AFK and we need to merge the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change starting Instance flow to
Why?
STH can be restarted without stopping Instances. Instances will reconnect when STH becomes available.
🧊 Important
This PR covers JS Runner only. Python runner can be started in new way but it can't reconnect after it has been disconnected.
Clickup Task:
https://app.clickup.com/t/24308805/VDM-385
Review checks:
These aspects need to be checked by the reviewer: