Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STH] Instance stop and kill body params fix #673

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

ErykSol
Copy link
Contributor

@ErykSol ErykSol commented Sep 6, 2022

Currently instance endpoints /_kill and /_stop requires to pass in body InstatnceStatus Code to succesfully pass request validation which makes it impossible to use by regular user.

This PR changes required body params to be optional, and changes reqest body format from:
[InstanceStatus.SomeCode, {...requiredParams}]
to
{...optionalParams}

Review checks:

These aspects need to be checked by the reviewer:

  • Verify and confirm operation
  • All STH tests pass
  • Documentation is updated or no changes

Verification:

  1. /_stop
    Invalid timeout format:
    image

Invalid canCallKeepalive format:
image

Valid params provided:
image

No params provided (use of default params):
image

  1. /_kill
    Invalid params format:
    image

Valid params provided:
image

No params provided (use of default params):
image

@ErykSol ErykSol merged commit 29aab4d into devel Sep 6, 2022
@ErykSol ErykSol deleted the fix/sth_stop_and_kill_endpoint branch September 6, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants