Fix handling of boolean flags in elliptical path commands #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ede123
commented
Apr 8, 2018
Ede123
commented
- properly parse paths without space after boolean flags (fixes scour needs unnecessary spaces in d-attribute of path-tag #161)
- omit space after boolean flag to shave off a few bytes when not using renderer workarounds
'large-arc-flag' and 'sweep-flag' do not need to be separated from the following path data with comma or whitespace. It results in ambiguous numbers but it's actually valid SVG...
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 91.51% 93.15% +1.63%
==========================================
Files 5 5
Lines 2121 2132 +11
==========================================
+ Hits 1941 1986 +45
+ Misses 180 146 -34
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.