Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testing NodeJS container in OpenShift 4 environment #249

Merged
merged 4 commits into from
May 20, 2021
Merged

Support testing NodeJS container in OpenShift 4 environment #249

merged 4 commits into from
May 20, 2021

Conversation

phracek
Copy link
Member

@phracek phracek commented Jul 30, 2020

This commit brings a new functionality for testing SCL images under OpenShift 4.4 environment

@phracek phracek changed the title [WIP] Support testing NodeJS container in OpenShift 4 environment Support testing NodeJS container in OpenShift 4 environment Aug 17, 2020
@phracek
Copy link
Member Author

phracek commented Sep 15, 2020

@phracek
Copy link
Member Author

phracek commented Sep 22, 2020

OpenShift 4 tests failure should be fixed by sclorg/rhscl-container-ci#41

@sclorg sclorg deleted a comment from pkubatrh Sep 22, 2020
@phracek
Copy link
Member Author

phracek commented Sep 22, 2020

OpenShift 4 testing error is fixed by sclorg/container-common-scripts#171

@phracek
Copy link
Member Author

phracek commented Sep 23, 2020

OpenShift 4 failed because of s2i-nodejs 14 version is not built. This bug is fixed by sclorg/container-common-scripts#172

@pkubatrh
Copy link
Member

Updated F33 s2i-base image is out now, lets try again for green tests.
[test]

@phracek
Copy link
Member Author

phracek commented Oct 23, 2020

New Jenkins Job for RHEL7

[test]

@phracek
Copy link
Member Author

phracek commented Oct 26, 2020

Another test in new Jenkins instance also for OpenShift 4

[test-openshift-4]

@phracek
Copy link
Member Author

phracek commented Oct 26, 2020

[test]

@phracek
Copy link
Member Author

phracek commented Mar 9, 2021

[test][test-openshift-4]

@phracek
Copy link
Member Author

phracek commented Mar 16, 2021

This PR is blocked by sclorg/container-common-scripts#192

@phracek
Copy link
Member Author

phracek commented May 3, 2021

The test in OpenShift 4 will be solved automatically as soon as #272 is merged.

@phracek
Copy link
Member Author

phracek commented May 4, 2021

@yselkowitz I have removed in this pull request NodeJS 10 from the imagestreams. NodeJS reached EOL. Does it make sense to you?

@yselkowitz
Copy link
Contributor

@yselkowitz I have removed in this pull request NodeJS 10 from the imagestreams. NodeJS reached EOL. Does it make sense to you?

Sorry, I don't understand. How does this relate to #271?

@phracek
Copy link
Member Author

phracek commented May 5, 2021

[test][test-openshift-4]

@phracek
Copy link
Member Author

phracek commented May 6, 2021

CI died

[test][test-openshift-4]

@phracek
Copy link
Member Author

phracek commented May 10, 2021

OpeShift 4 CI is gack again.

Let's try run test suite

[test-openshift-4]

@phracek
Copy link
Member Author

phracek commented May 12, 2021

[test-openshift-4]

@phracek
Copy link
Member Author

phracek commented May 13, 2021

OpenShift 4 tests are failing on this error only for version 14. The rest is fine.

In project sclorg-test-25857 on server <IP>

<IP>(svc/nodejs-testing)
  dc/nodejs-testing deploys istag/nodejs-testing:latest <-
    bc/nodejs-testing source builds https://github.com/sclorg/nodejs-ex.git#master on istag/nodejs:14
      not built yet
    deployment #1 waiting on image or update

Warnings:
  * bc/nodejs-testing builds from istag/nodejs:14, but the image stream tag does not exist.
    try: istag/nodejs:14 needs to be imported.
  * The image trigger for dc/nodejs-testing will have no effect until istag/nodejs-testing:latest is imported or created by a build.
  * istag/nodejs-testing:latest needs to be imported or created by a build.
    try: oc start-build nodejs-testing

View details with 'oc describe <resource>/<name>' or list everything with 'oc get all'.

phracek added 2 commits May 13, 2021 17:16
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented May 13, 2021

rebased

[test][test-openshift-4]

@phracek
Copy link
Member Author

phracek commented May 17, 2021

[test-openshift-4]

phracek added 2 commits May 20, 2021 10:33
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented May 20, 2021

[test][test-openshift-4]

@phracek
Copy link
Member Author

phracek commented May 20, 2021

@hhorak @pkubatrh Finally. All check PASSED :) Can we merge it?

@phracek phracek merged commit 697f534 into sclorg:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants