-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master 0.1.0 beta review #21
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
test framework + DNS + DatagramChannel Numerous improvementts: Test framework + DNS + DatagramChannel. Changes: - Improve API - DatagramChannel - PingPong server works - DatagramSocket - PingPong server works - DNS TXT record lookup works - Full mock network ("tiny" topology) works for unit tests - PathServer API abstraction --------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
--------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
a3a9167
to
50dcb8f
Compare
The DatagramChannel is mixing up the "connected" state of the underlying channel (to first hop) and the implemented channel (to a remote host). --------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
* Global JUnit settings --------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
* /etc/scion/hosts and /etc/resolv.conf --------- Co-authored-by: Tilmann Zäschke <tilmann.zaeschke@inf.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete review for 0.1.0 release.
This change is