Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw exception on empty path list #160

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

tzaeschke
Copy link
Collaborator

PathPolicies should accept or produce empty path lists without throwing an exception,

@tzaeschke tzaeschke self-assigned this Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/main/java/org/scion/jpan/PathPolicy.java 92.85% 0 Missing and 1 partial ⚠️
.../main/java/org/scion/jpan/ScionDatagramSocket.java 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...n/java/org/scion/jpan/AbstractDatagramChannel.java 85.21% <100.00%> (+0.37%) 88.00 <2.00> (+2.00)
...main/java/org/scion/jpan/ScionDatagramChannel.java 82.60% <100.00%> (+0.15%) 24.00 <0.00> (ø)
src/main/java/org/scion/jpan/ppl/PplPolicy.java 82.96% <ø> (+0.94%) 37.00 <0.00> (-1.00) ⬆️
src/main/java/org/scion/jpan/PathPolicy.java 97.82% <92.85%> (-0.22%) 1.00 <0.00> (-2.00)
.../main/java/org/scion/jpan/ScionDatagramSocket.java 55.34% <66.66%> (ø) 59.00 <0.00> (ø)

... and 1 file with indirect coverage changes

@tzaeschke tzaeschke merged commit 65a96f6 into master Feb 4, 2025
9 checks passed
@tzaeschke tzaeschke deleted the fix/160-path-policy-changes branch February 4, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant