Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don´t start SHIM if port range = ALL #139

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

tzaeschke
Copy link
Collaborator

No description provided.

@tzaeschke tzaeschke self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...in/java/org/scion/jpan/internal/LocalTopology.java 0.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/org/scion/jpan/ScionService.java 71.47% <100.00%> (+0.57%) 64.00 <4.00> (+4.00)
src/main/java/org/scion/jpan/internal/Shim.java 73.97% <100.00%> (-1.03%) 17.00 <0.00> (-1.00)
...in/java/org/scion/jpan/internal/LocalTopology.java 82.57% <0.00%> (-0.64%) 26.00 <0.00> (ø)

@tzaeschke tzaeschke merged commit eb9de4d into master Nov 18, 2024
9 checks passed
@tzaeschke tzaeschke deleted the fix/139-no-SHIM-for-ALL branch November 18, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant