Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path shortcuts #104

Merged
merged 16 commits into from
Aug 14, 2024
Merged

Path shortcuts #104

merged 16 commits into from
Aug 14, 2024

Conversation

tzaeschke
Copy link
Collaborator

Implement path shortcuts and on-path

@tzaeschke tzaeschke self-assigned this Jun 28, 2024
@tzaeschke tzaeschke force-pushed the fix/104-shortcuts branch 2 times, most recently from 7d5d086 to 5cc48cb Compare July 16, 2024 10:57
@tzaeschke tzaeschke force-pushed the fix/104-shortcuts branch 2 times, most recently from 674c03f to f26ea0b Compare July 26, 2024 11:35
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 90.03984% with 25 lines in your changes missing coverage. Please review.

Files Patch % Lines
...rc/main/java/org/scion/jpan/internal/Segments.java 91.37% 12 Missing and 8 partials ⚠️
src/main/java/org/scion/jpan/ScionService.java 50.00% 4 Missing and 1 partial ⚠️
Files Coverage Δ Complexity Δ
src/main/java/org/scion/jpan/Constants.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/org/scion/jpan/PathMetadata.java 48.57% <100.00%> (ø) 13.00 <0.00> (ø)
src/main/java/org/scion/jpan/Scmp.java 88.60% <100.00%> (+0.86%) 4.00 <0.00> (ø)
src/main/java/org/scion/jpan/ScmpChannel.java 84.21% <100.00%> (ø) 18.00 <0.00> (ø)
src/main/java/org/scion/jpan/ScionService.java 65.91% <50.00%> (-0.75%) 50.00 <1.00> (ø)
...rc/main/java/org/scion/jpan/internal/Segments.java 85.11% <91.37%> (+2.88%) 99.00 <73.00> (+34.00)

... and 2 files with indirect coverage changes

@tzaeschke tzaeschke force-pushed the fix/104-shortcuts branch 2 times, most recently from d0e0126 to 032f7f0 Compare August 12, 2024 08:32
@tzaeschke tzaeschke merged commit 5362a67 into master Aug 14, 2024
8 checks passed
@tzaeschke tzaeschke deleted the fix/104-shortcuts branch August 14, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant