add jackson-dataformat-smile to pom #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrueden
force-pushed
the
jackson-dataformat-smile
branch
2 times, most recently
from
cb1a7c8 to
6896760
Compare
Until the new failures can be investigated in detail.
Co-authored-by: Curtis Rueden <ctrueden@wisc.edu>
ctrueden
force-pushed
the
jackson-dataformat-smile
branch
from
6896760 to
0751d6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our plugin Mars uses Jackson a lot for basically all file storage. We use smile encoding to decrease the size of json files. Would it be possible to manage jackson-dataformat-smile in pom-scijava? This pull request adds it.
I noticed now the jackson jars are coming with Fiji, except for jackson-dataformat-smile. Also, this now created some version skew with our update site that is still at 2.11. I am in the process of fixing that and maybe I could just remove the Jackson jars from our update site. But then would it also be possible to add the jackson-dataformat-smile jar to Fiji? I know that adds more bloat
Already managing the version here would help.