Add support for temporal point clouds #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Nov 12, 2024
jorgensd
reviewed
Nov 12, 2024
finsberg
force-pushed
the
xdmf-temporal-pointcloud
branch
from
31544b5 to
db0acb8
Compare
jorgensd
reviewed
Nov 12, 2024
finsberg
force-pushed
the
xdmf-temporal-pointcloud
branch
from
30b1d3a to
53f9484
Compare
|
Still need to implement "append" method but I think this could be a "Good first issue" for new contributors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adress #58
In my opinion we could remove the old code for writing point clouds and just use this instead. If so, we might want to add a deprecation warning.
Current only writing is possible, but I think we could add support for read and append in the future.