-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding --prefix in spin build #241
Conversation
@stefanv I think your existing windows tests do run on powershell. You can see what shell an actions step is running by expanding the input details. ![]() So I think the issue isn't powershell so much as how python is set up. I can trigger the problem using a python installed via micromamba and uv on Windows. |
We don't actually install to The tests seem happy, though, so perhaps you're right! |
(It would be good to trigger a Windows failure in the test suite, so that we don't break this again in the future by accident.) |
This is very helpful; I could make a matrix entry for that. |
For uv you can do something like this on github actions:
|
05668f0
to
144e4b9
Compare
Darn, it looks like simply installing python from uv wasn't enough to trigger it in the spin tests. I'm not sure how to write a test using the existing framework to trigger what I'm seeing with NumPy. I guess I could add a CI job that just builds NumPy? I'll leave it up to you, please feel free to push to this PR if you want to adjust things. |
Thank you so much, Nathan. I'm out until next week, but will take a look at it then. |
ea50a2e
to
035b28b
Compare
OK, I've added a new I also ran into #242, I think it's too easy for commands that projects want to override to go out of sync with upstream improvements. |
c03ffbf
to
b1796c8
Compare
I also just checked on the Windows system I originally had a problem on - changing the default prefix to |
Hi, any chance we can get this reviewed? I tried again today to set up Windows tests for NumPy using |
Thanks @ngoldbaum, and sorry for the delay. |
Fixes #240
This lets users override --prefix. Right now it's hard-coded, which leads to breakage on windows sometimes.