Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make backgroundScan default to true #46

Closed
schmich opened this issue Apr 26, 2017 · 0 comments
Closed

Make backgroundScan default to true #46

schmich opened this issue Apr 26, 2017 · 0 comments
Milestone
2.0.0

Comments

@schmich
Copy link
Owner

schmich commented Apr 26, 2017

By default, backgroundScan should be true to avoid potentially confusing behavior (see #43). By making the user explicitly set backgroundScan to false, they should understand why the preview video disappears and reappears.
@schmich schmich added this to the 2.0.0 milestone Apr 26, 2017
scmx added a commit to scmx/instascan that referenced this issue May 21, 2017
@scmx
Merge branch 'master' into replace-babel-polyfill-with-transform-runtime
16bfb26 
* master:
  Formatting.
  Fix schmich#46: Make backgroundScan default to true.
  streamUrl -> stream
  Removed usage of window.URL.createObjectURL(...) in favour of returning stream directly. This has been done, since createObjectURL has been deprecated (and using it breaks WebRTC functionality when using webrtc-adapter)
  Add note about iOS non-compatibility.
  Improve scanner options formatting.
  Rename VideoAccessError to MediaError.
  Update README to include getUserMedia error handling.
  Add error handling to README example.
  Remove old app. Update deployment commit message.
  Add VideoAccessError to wrap errors from getUserMedia. Update demo to handle errors correctly.
  Add Travis support with deployments.
  Add demo link to README.
  Do not make demo video fullscreen.
  Fix camera name bug in demo.
  Add GitHub Pages project demo.
  Update example to include message when no cameras are found.
  Rename gulp 'dist' target to 'release'.
  var -> let
  Add release publication workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@schmich