improvement: Also allow nonboostrapped to fall back to the last nightly #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly with the same RC version will have the same tasty version, so it will be able to work correctly.
|
Just tested it out and it seems to work well. |
|
I will go ahead and merge this so that the compiler team can check it out. |
tgodzik
commented
Feb 3, 2023
| if original.isEmpty && scalaVersion.contains("NIGHTLY") => | ||
| if original.isEmpty && | ||
| scalaVersion.contains("NIGHTLY") || | ||
| scalaVersion.contains("nonbootstrapped") => |
There was a problem hiding this comment.
Hopefully no one minds since it's a super small change and impacts miniscule amount of people.
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Feb 8, 2023
…#16816) This would require just setting `bspEnabled := true`, but not for sjsJUnitTests which seem to cause inifinite loop of compilations. I also need to work a bit on Bloop to also make it work. This still needs scalameta/metals#4938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly with the same RC version will have the same tasty version, so it will be able to work correctly.
Unfortunately, it seems currently Bloop doesn't compile the nonbootstrapped, since it's missing bridges. We might need to use PRs from Alex.