Prevent concurrent access to SJS linker #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR #381 I've used a fully synchronous execution context because somehow the linker was accessed concurrently.
What I failed to understand is that execution context was needed in two places - for IR cache and for the linker itself, as linking returns a Future.
Therefore sequential snippets were actually executed concurrently, and the Linker was complaining
Now, I don't know if this will solve an issue I've seen with mdoc deadlocking on some of my
mdoc:jsprojects, but this surely makes usage of EC more generic and shouldn't hurt.