Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache utilities results #691

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Cache utilities results #691

merged 4 commits into from
Feb 8, 2025

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Feb 5, 2025

Caching inside a macro:

  • summoning Transformers/PartialTransformers/OuterTransformers
  • resolving IterableOrArray/ProductType/SealedHierchies/ValueTypes
  • resolving OptionalValue/TotallyBuildIterable/PartiallyBuildIterable

The change is not tremendous but we can try it and ask for feedback - I cannot see regression in compile time, so it should be safe (at least not harmful).

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.99%. Comparing base (1db5076) to head (17090e3).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...former/integrations/PartialOuterTransformers.scala 0.00% 4 Missing ⚠️
...nsformer/integrations/TotalOuterTransformers.scala 0.00% 3 Missing ⚠️
...d/chimney/internal/compiletime/ExprsPlatform.scala 71.42% 2 Missing ⚠️
...ernal/compiletime/datatypes/IterableOrArrays.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
+ Coverage   86.92%   86.99%   +0.06%     
==========================================
  Files         183      183              
  Lines        8185     8128      -57     
  Branches      785      793       +8     
==========================================
- Hits         7115     7071      -44     
+ Misses       1070     1057      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review February 8, 2025 19:53
@MateuszKubuszok MateuszKubuszok merged commit 551507f into master Feb 8, 2025
23 of 24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the cache-utilities-results branch February 8, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant