Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala 3's enum specs #347

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Add Scala 3's enum specs #347

merged 2 commits into from
Aug 3, 2023

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Aug 3, 2023

We didn't test Scala 3 enums explicitly so it would be a good idea to test it

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.32% 🎉

Comparison is base (501d758) 78.78% compared to head (624891c) 79.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           scala-3     #347      +/-   ##
===========================================
+ Coverage    78.78%   79.10%   +0.32%     
===========================================
  Files          106      106              
  Lines         3988     3973      -15     
  Branches       173      156      -17     
===========================================
+ Hits          3142     3143       +1     
+ Misses         846      830      -16     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review August 3, 2023 15:23
@MateuszKubuszok MateuszKubuszok requested a review from krzemin August 3, 2023 15:23
@MateuszKubuszok MateuszKubuszok merged commit 33a0498 into scala-3 Aug 3, 2023
@MateuszKubuszok MateuszKubuszok deleted the enum-tests branch August 3, 2023 15:31
@MateuszKubuszok MateuszKubuszok removed the request for review from krzemin August 3, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests and then official support for Scala 3 macros handling Scala 2.13 code and vice-versa
1 participant