Update base version to 3.4.1-RC1 #19469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can check MiMa against 3.4.0-RC1 to ensure that the API has not changed. Though that version has a couple of mistakes that will be fixed in 3.4.0-RC2.
nicolasstucki
force-pushed
the
update-base-version
branch
from
7ed5f6f to
373b600
Compare
This makes it evident which changes are backwards incompatible and which are froward incompatible. Previously it was not clear which changes were backwards incompatible and which were forwards incompatible.
|
can we validate this against #13447? |
We should. But don't know what the best way to validate this is yet. |
nicolasstucki
commented
Jan 18, 2024
| ProblemFilters.exclude[MissingFieldProblem]("scala.runtime.stdLibPatches.language.3.5"), | ||
| ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$3$u002E5$"), | ||
| ProblemFilters.exclude[MissingClassProblem]("scala.runtime.stdLibPatches.language$3$u002E5$minusmigration$"), | ||
| ) |
There was a problem hiding this comment.
With 3.4.0-RC2, the two lists LibraryBackwards/ LibraryForward should be empty.
Kordyjan
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19321
We are currently releasing nightlies with the wrong version. We should update this now. We do not need to wait until we can update the reference version.
Now we can check MiMa against 3.4.0-RC1 to ensure that the API has not changed.
However, that version has a couple of mistakes that will be fixed in 3.4.0-RC2.