Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated URL ctor in scaladoc #17426

Merged
merged 1 commit into from
May 8, 2023

Conversation

som-snytt
Copy link
Contributor

Follow-up to #17403 includes scaladoc.

@ckipp01
Copy link
Member

ckipp01 commented May 8, 2023

Screenshot 2023-05-08 at 09 13 07

@romanowski really really really approves this 😆

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 looks good, thanks @som-snytt.

@ckipp01 ckipp01 merged commit 830230f into scala:main May 8, 2023
@som-snytt som-snytt deleted the tweak/scaladoc-jdk20 branch May 8, 2023 08:59
@romanowski
Copy link
Contributor

@romanowski really really really approves this 😆

It is testament to the GitHub UI :) As they say 3 4 times the charm :D

@som-snytt
Copy link
Contributor Author

@ckipp01 I'm curious how this PR was merged. Is it without a merge commit, but a rebase and merge? I see the difference because git branch -d won't work locally. I haven't had coffee yet this morning.

@ckipp01
Copy link
Member

ckipp01 commented May 8, 2023

@ckipp01 I'm curious how this PR was merged. Is it without a merge commit, but a rebase and merge? I see the difference because git branch -d won't work locally. I haven't had coffee yet this morning.

I used whatever the default was, I think "Squash and merge". Maybe you already fetched upstream and synced? And since you deleted the branch here, it's deleted locally as well? Or do you mean it won't allow you to delete it locally?

@Kordyjan Kordyjan added this to the 3.3.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants