Initialization check for methods with non-hot parameters #13999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the method is `effectivelyFinal`, we don't have to resolve the method from the class (and hence tracking the `klass` within a `Hot` value is not needed). This limits the kinds of methods that can be annotated, but we will we removing annotations soon.
This reverts commit 151735e. For this pull request, it is better that we provide a hard-coded `isNonHotParams` method (which for now should be just "case class `apply` methods") and leave the annotation for when there is a later demand.
This makes the condition for a method to take non-hot parameters to be the `apply` method of a case class. A test case is also included.
natsukagami
commented
Dec 1, 2021
| @@ -0,0 +1,8 @@ | |||
| case class Case(b: Base) | |||
There was a problem hiding this comment.
This tests the Hot case in the call method but not Ref. How do I add such a case?
|
|
|
With previous commit applied: output.log |
|
This is now superseded by #14283. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@nonHotParametersannotation