Fix XMLEventReader does not handle ' properly #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fehmicansaglam
commented
Oct 20, 2015
•
fehmicansaglam
commented
- Fixes XMLEventReader does not handle ' properly #72
|
@fehmicansaglam I'm sorry this seems to have been ignored. it needs a rebase now. are you interested in doing a rebase? perhaps this comment will attract some reviewer attention. |
|
Sure, I will. |
|
are this and #89 duplicates? |
fehmicansaglam
force-pushed
the
master
branch
from
a30de4c to
35a9685
Compare
fehmicansaglam
force-pushed
the
master
branch
from
35a9685 to
3237688
Compare
|
@SethTisue yes, they are duplicates. According to your comment here, #89 is better. If so, I can close this. |
|
@SethTisue This one is good. I had assumed fixing the XMLEventReader bug would have broader impact. I was incorrect. I eventually cleared up my own confusion in this comment at #72. So PR #89 was a false lead, but also an attempt to understand the issues. |
ashawley
reviewed
Feb 16, 2017
| @@ -93,7 +93,7 @@ object Utility extends AnyRef with parsing.TokenTests { | |||
| * For reasons unclear escape and unescape are a long ways from | |||
| * being logical inverses. | |||
| */ | |||
| val pairs = Map( | |||
| private val pairs = Map( | |||
There was a problem hiding this comment.
Maybe annotate it as @deprecated first just in case a user happened to be importing it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.