-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JLine: completion for :
doesn't work very well
#12264
Comments
|
Could you please tell me about the expected results? Although I know something about repl, I still don't know what the problem is when I see this issue. @SethTisue |
here is how 2.12.13 behaves; this is the desired behavior:
|
Oh. It seems that adding a space after the question mark is just like 2.12.13, which is too weird.
|
yeah, off-by-one problem somewhere, I suppose? |
I took a quick look, because it's been my dream to someday understand jline completion. It's like the mirage of the oasis in the desert that recedes continuously. The completion result must include the colon. (For expression completion, the accumulator holds the current text.) With that fix:
Jline auto-escapes the space after the command. Ha, ha. I'll spend a few minutes with it later. Possibly, the "command line parser" will handle any shell escapes and quotes. Or maybe there is a setting to turn off escapes in jline. Worth noting that jline is built for "shell commands" and not "scala expressions". We supply the parser, but maybe other components are subject to this bias, such as completion results. |
The colon uses CommandParser, while the other commands use ScalaParser. |
REPL: improve tab-completion of `:`-prefixed commands (fixes scala/bug#12264)
@lrytz reports:
The text was updated successfully, but these errors were encountered: