[1.x] Make reproducibility toggleable for ConsistentAnalysisFormat
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
changed the title
ConsistentAnalysisFormatConsistentAnalysisFormat
Friendseeker
force-pushed
the
reproducible-toggleable
branch
from
b92fd51 to
653c45c
Compare
|
Reopening the PR, following discussion in #1496 (comment) |
eed3si9n
reviewed
Nov 18, 2024
Comment on lines
+211
to
+212
| if (reproducible) m.mapValues(_.withCompilationTimestamp(DefaultCompilationTimestamp)) | ||
| else m |
There was a problem hiding this comment.
so semantically, this is the only change, and the rest is rename?
There was a problem hiding this comment.
@eed3si9n could we have a review of this one please?
There was a problem hiding this comment.
LGTM.
FYI @szeiger we are gonna break the hermeticity for not sorted version.
eed3si9n
approved these changes
Nov 21, 2024
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.c. sbt/sbt#7790
This PR makes reproducibility of
ConsistentAnalysisFormattoggle-able via new flagreproducibleto preserve timestamp information needed for Zinc to conduct certain invalidation decisions. Users who uses reproducible build tool can choose to setreproducibleflag on (at the expense of less accurate invalidation), and most users who don't use reproducible build tool can setreproducibleoff for more accurate invalidation.Build tools using Zinc may need to surface the flag to users, and are encouraged to set
reproducible = falseas default option.