Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Remove compile warnings #1458

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[2.x] Remove compile warnings #1458

merged 1 commit into from
Oct 14, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Oct 13, 2024 •
edited
Loading

This PR removes almost all warnings outside of compiler bridge module.

@Friendseeker Friendseeker force-pushed the clean-compile-warnings branch from 7d68645 to d2420e9 Compare October 13, 2024 22:47
@Friendseeker Friendseeker force-pushed the clean-compile-warnings branch from d2420e9 to ba8f02e Compare October 13, 2024 22:52
@Friendseeker Friendseeker changed the title [2.x] Remove compiler warnings [2.x] Remove compile warnings Oct 13, 2024
eed3si9n
eed3si9n approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd be forward/back porting patches between 1.x and 2.x for a while, so we don't want to deviate too far, but I think this is good. Thanks!

@adpi2 adpi2 merged commit 2cd1149 into sbt:develop Oct 14, 2024
8 checks passed
@Friendseeker Friendseeker deleted the clean-compile-warnings branch October 14, 2024 08:32
@Friendseeker Friendseeker mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@adpi2 adpi2 Awaiting requested review from adpi2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Friendseeker @eed3si9n @adpi2