[2.x] Fix analysis of Java compilation to jar #1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
changed the title
- JavaClassFileMapper: to map classFile from temp folder to output jar - CachedClassLoader: to cache loading classes and class files - JavaAnalyzer: to compute the dependency analysis
adpi2
force-pushed
the
2.x-compile-straight-to-jar
branch
from
346e86b to
54ceb43
Compare
|
Actually I have the same or similar issue with |
|
Superseded by #1376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix the
java-mixedtest with straight-to-JAR compilation enabled. The difficulty here was to remap class files from the previous JAR (Scala compilation) to class files in the output JAR.But most of the PR is a refactoring of
JavaAnalyzeto reduce nesting and parameter passing.This will be needed by sbt/sbt#7592