Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zinc-scripted show up in IntelliJ #1298

Closed
wants to merge 1 commit into from
Closed

Make zinc-scripted show up in IntelliJ #1298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,11 +652,10 @@ lazy val zincClassfile = (projectMatrix in internalPath / "zinc-classfile")

// re-implementation of scripted engine
lazy val zincScripted = (projectMatrix in internalPath / "zinc-scripted")
.dependsOn(zinc % "compile;test->test")
.dependsOn(zinc % "compile;test->test", compilerBridge % "compile;test->test")
.enablePlugins(BuildInfoPlugin)
.settings(
baseSettings,
ideSkipProject := true, // otherwise IntelliJ complains
publish / skip := true,
name := "zinc Scripted",
Compile / buildInfo := Nil, // Only generate build info for tests
Expand All @@ -667,9 +666,6 @@ lazy val zincScripted = (projectMatrix in internalPath / "zinc-scripted")
)
.defaultAxes(VirtualAxis.jvm, VirtualAxis.scalaPartialVersion(scala212))
.jvmPlatform(scalaVersions = List(scala212))
.configure(
_.dependsOn(compilerBridge210, compilerBridge211, compilerBridge212, compilerBridge213)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes zincScripted depend on all compiler bridge JARs whereas the one above will only depend on the ones for Scala 2.12? I wonder if this was meant to create build order dependency so calling the scripted test would force rebuilding compiler bridges when we change the bridge imple. Could you check if that still works plz?

)
.configure(addSbtUtilScripted)

lazy val zincScripted212 = zincScripted.jvm(scala212)
Expand Down