Fixes stackoverflow #163
Merged
Fixes stackoverflow #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
force-pushed
the
wip/stackoverflow
branch
from
ca4bb2a to
1afb172
Compare
Problem ------- Given a recurisve type that includes itself as a field, Contraband currently stackoverflows, trying to keep looking for the format type. Solution -------- Check if the field type is locally defined, and avoid traversing into it.
eed3si9n
force-pushed
the
wip/stackoverflow
branch
from
1afb172 to
3957892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Given a recurisve type that includes itself as a field,
Contraband currently stackoverflows, trying to keep looking for the
format type.
Solution
Check if the field type is locally defined, and avoid traversing into
it.