implement reference equality for scala #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to fix this for scala 2.12... |
|
Ready for review |
eed3si9n
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
overall LGTM
Could you update the docs - https://github.com/sbt/contraband/blob/master/docs/02-code-generation.md, and also the description of this PR stating the motivation for this change (runtime perf I assume?)
|
@eed3si9n can you do a release so we get this change in sbt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve runtime performance of equals method by testing for reference equality first.