Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "pattern var x in method equals is never used" warning in generated code #108

Merged
merged 2 commits into from
Oct 21, 2017
Merged

Fix "pattern var x in method equals is never used" warning in generated code #108

merged 2 commits into from
Oct 21, 2017

Conversation

freeman42x
Copy link
Contributor

eed3si9n
eed3si9n approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
Nice talking to you.

@freeman42x
Copy link
Contributor Author

@eed3si9n Nice talking to you too. And many thanks to OlegYch_ and earldouglas also.

@freeman42x
Copy link
Contributor Author

@eed3si9n Ah, I need to update the tests also I think.

@freeman42x
Copy link
Contributor Author

Woohoo haha

@eed3si9n eed3si9n merged commit 76c9bae into sbt:master Oct 21, 2017
@dwijnand
Copy link
Member

Nice one.

@dwijnand
Copy link
Member

dwijnand commented Dec 6, 2017

Can we cut a release with this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freeman42x @dwijnand @eed3si9n