Support HTTP Basic auth in Rack adapter #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rogerleite, sorry for taking so long to respond and thanks for the tip. I'll write a test using |
milgner
force-pushed
the
feature/rack_basic_auth
branch
from
89c2961 to
6d9d0ab
Compare
|
Ok, amended the commit with a proper test. Looking good now. |
|
Thanks @milgner! Sorry for the super late reply! 😞 |
rogerleite
added a commit
that referenced
this pull request
Jan 20, 2016
Support HTTP Basic auth in Rack adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure how to best add a proper spec for this, so feel free to comment and I'll add it.