Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support global node #944

Merged
merged 44 commits into from
Sep 9, 2024
Merged

feat: Support global node #944

merged 44 commits into from
Sep 9, 2024
+628 −41

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Sep 4, 2024 •
edited
Loading

Description

Support global node. Node version can be set via valid SemVer with v prefix, alias resolution, and fuzzy matching for major or major.minor versions.

@tianfeng92 tianfeng92 added the enhancement New feature or request label Sep 4, 2024
@tianfeng92 tianfeng92 marked this pull request as ready for review September 5, 2024 18:02
@tianfeng92 tianfeng92 requested a review from a team as a code owner September 5, 2024 18:02
@tianfeng92 tianfeng92 marked this pull request as draft September 5, 2024 18:23
@tianfeng92 tianfeng92 marked this pull request as ready for review September 5, 2024 21:08
alexplischke
alexplischke reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs:

  • json schema update
  • segment tracking of user specified node version

alexplischke
alexplischke reviewed Sep 6, 2024
View reviewed changes
tianfeng92 and others added 23 commits September 6, 2024 15:30
@tianfeng92
when runtime reaches its EOL, just warn user
26d163b
@tianfeng92
refine runtime validation
e6772d9
@tianfeng92
exitCode is really unnecessary
8e1f63b
@tianfeng92
rename setRunime to setNodeRuntime
835c173
@tianfeng92
add JSON schema
1967e57
@tianfeng92
rename namingMap
16d4712
@tianfeng92
rename Runtime struct fields
3ee9b2a
@tianfeng92
rename SupportGlobalNode to SupportsRuntime
1304bcf
@tianfeng92
rename SelectNode to Find
c3a3652
@tianfeng92
lower alias before matching runtime
6f2a657
@tianfeng92
introduce removal date
9f3be31
@tianfeng92
Update internal/runtime/runtime.go
8fa8737 
Co-authored-by: Alex Plischke <alex.plischke@saucelabs.com>
@tianfeng92
track node version usage
4af5a2a
@tianfeng92
update unit test
960df5d
@tianfeng92
make SupportsRuntime more generic
29d27f7
@tianfeng92
update method comment
8b53174
@tianfeng92
lower alias inside of findRuntimeByAlias
c908e3e
@tianfeng92
refine runtime validation msg
d7759c4
@tianfeng92
hmm.. do not change parameter value
d25e110
@tianfeng92
set default runtime if it is supported but not set
586f3f1
@tianfeng92
update JSON schema
3315fc8
@tianfeng92
refine
b3e6401
@tianfeng92
refine validation msg
d87b081
@tianfeng92 tianfeng92 merged commit a6a8bd1 into main Sep 9, 2024
16 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-2675 branch September 9, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhan83 mhan83 mhan83 left review comments

@alexplischke alexplischke alexplischke approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tianfeng92 @alexplischke @mhan83