fix: Support nullable strictSSL

saucelabs · Aug 14, 2024 · c716238 · c716238
1 parent 5f8d9d8
commit c716238
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/src/utils.ts b/src/utils.ts
@@ -131,7 +131,7 @@ export function getNpmConfig(runnerConfig: NpmConfigContainer) {
   }
   const cfg: { [key: string]: string | boolean | null } = {
     registry: runnerConfig.npm.registry || getDefaultRegistry(),
-    'strict-ssl': runnerConfig.npm.strictSSL !== false,
+    'strict-ssl': runnerConfig.npm.strictSSL ?? null,
     // Setting to false to avoid dealing with the generated file.
     'package-lock': runnerConfig.npm.packageLock === true,
     'legacy-peer-deps':

diff --git a/tests/unit/src/__snapshots__/utils.spec.ts.snap b/tests/unit/src/__snapshots__/utils.spec.ts.snap
@@ -111,7 +111,7 @@ exports[`utils .prepareNpmEnv should use default registry 1`] = `
     "package-lock": false,
     "registry": "https://registry.npmjs.org",
     "save": false,
-    "strict-ssl": true,
+    "strict-ssl": null,
     "update-notifier": false,
   },
 ]
@@ -133,7 +133,7 @@ exports[`utils .prepareNpmEnv should use env var for registry 1`] = `
     "package-lock": false,
     "registry": "npmland.io",
     "save": false,
-    "strict-ssl": true,
+    "strict-ssl": null,
     "update-notifier": false,
   },
 ]
@@ -179,7 +179,7 @@ exports[`utils .prepareNpmEnv should use true as the default value for strictSSL
     "package-lock": false,
     "registry": "https://registry.npmjs.org",
     "save": false,
-    "strict-ssl": true,
+    "strict-ssl": null,
     "update-notifier": false,
   },
 ]
@@ -201,7 +201,7 @@ exports[`utils .prepareNpmEnv should use true as the default value for strictSSL
     "package-lock": false,
     "registry": "https://registry.npmjs.org",
     "save": false,
-    "strict-ssl": true,
+    "strict-ssl": null,
     "update-notifier": false,
   },
 ]
@@ -223,7 +223,7 @@ exports[`utils .prepareNpmEnv should use user registry 1`] = `
     "package-lock": false,
     "registry": "registryland.io",
     "save": false,
-    "strict-ssl": true,
+    "strict-ssl": null,
     "update-notifier": false,
   },
 ]

diff --git a/tests/unit/src/utils.spec.ts b/tests/unit/src/utils.spec.ts
@@ -56,9 +56,9 @@ describe('utils', function () {
       expect(npmConfig).toHaveProperty('package-lock');
     });
 
-    it('should set strictSSL to true by default', function () {
+    it('should set strictSSL to null if not set', function () {
       const npmConfig = getNpmConfig(emptyConfig);
-      expect(npmConfig).toHaveProperty('strict-ssl', true);
+      expect(npmConfig).toHaveProperty('strict-ssl', null);
     });
 
     it('should set strictSSL from runner config', function () {
@@ -74,10 +74,6 @@ describe('utils', function () {
       runnerConfig.npm.strictSSL = true;
       npmConfig = getNpmConfig(runnerConfig);
       expect(npmConfig).toHaveProperty('strict-ssl', true);
-
-      runnerConfig.npm.strictSSL = 'truthy?';
-      npmConfig = getNpmConfig(runnerConfig);
-      expect(npmConfig).toHaveProperty('strict-ssl', true);
     });
 
     it('should set packageLock to false by default', function () {