-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct asset name in release pipeline #246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes. So is this change going to break the release workflow though? A lot of the steps after parsing the ASSET_ID has conditions like:
- name: Checkout
uses: actions/checkout@v3
if: ${{ steps.prep.outputs.asset_id == '' }}
with:
ref: ${{ steps.prep.outputs.version }}
I checked the release pipelines, the original PR, as well as other runners' pipeline. I don't find any |
One-line summary
The asset name in release pipeline is wrong. Use
playwright
instead oftestcafe
. 🤷♀️