Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct asset name in release pipeline #246

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Conversation

tianfeng92
Copy link
Contributor

One-line summary

The asset name in release pipeline is wrong. Use playwright instead of testcafe. 🤷‍♀️

@tianfeng92 tianfeng92 requested a review from a team as a code owner February 13, 2024 01:27
Copy link
Contributor

@mhan83 mhan83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. So is this change going to break the release workflow though? A lot of the steps after parsing the ASSET_ID has conditions like:

- name: Checkout
  uses: actions/checkout@v3
  if: ${{ steps.prep.outputs.asset_id == '' }}
  with:
    ref: ${{ steps.prep.outputs.version }}

@tianfeng92
Copy link
Contributor Author

Yikes. So is this change going to break the release workflow though? A lot of the steps after parsing the ASSET_ID has conditions like:

- name: Checkout
  uses: actions/checkout@v3
  if: ${{ steps.prep.outputs.asset_id == '' }}
  with:
    ref: ${{ steps.prep.outputs.version }}

I checked the release pipelines, the original PR, as well as other runners' pipeline. I don't find any asset_id in the API and it's always empty whether it's official release or beta release. Also I can't really recall why it's introduced and what it wants to solve. I'm going to discuss it in standup and see if we can remove this check.

@tianfeng92 tianfeng92 merged commit 23f7a97 into main Feb 13, 2024
29 checks passed
@tianfeng92 tianfeng92 deleted the fix-release-step branch February 13, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants