Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve JUnit generation #245

Merged
merged 5 commits into from
Feb 13, 2024
Merged

chore: Improve JUnit generation #245

merged 5 commits into from
Feb 13, 2024

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Feb 10, 2024

Enhancements to JUnit File Generation

Description

  • Uses console.warn to issue warnings when there are failures in merging JUnit files.
  • Adds warning message when the source JUnit file doesn't exist.

@tianfeng92 tianfeng92 marked this pull request as ready for review February 12, 2024 17:23
@tianfeng92 tianfeng92 requested a review from a team as a code owner February 12, 2024 17:23
Copy link

@alexplischke alexplischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For TestCafe, a warning is issued here, but not for playwright? Some consistency would be nice 🙏

@tianfeng92 tianfeng92 merged commit ffaec15 into main Feb 13, 2024
29 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-2751 branch February 13, 2024 00:34
@tianfeng92 tianfeng92 restored the DEVX-2751 branch February 13, 2024 00:58
@tianfeng92 tianfeng92 deleted the DEVX-2751 branch February 13, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants