-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle verbosity argument to obtain in pip 22.x + fix CI #311
Conversation
afa6c8a
to
4330ba2
Compare
@@ -41,7 +41,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
python-version: [3.6, 3.7, 3.8, 3.9, "3.10"] | |||
python-version: [3.7, 3.8, 3.9, "3.10"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the quotes around 3.10 are necessary. But you didn't do it, so it does not matter so much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, it is a common quirk of yaml, 3.10
will be parsed as 3.1
(float). In fact all 3.x
if not quoted, are parsed as floats, but only 3.10
changes the meaning.
New version of pip requires a verbosity argument and
pip-shims
has already updated to support it:sarugaku/pip-shims#79
This will support pipenv: https://github.com/pypa/pipenv/pull/4969/files
Includes cleanup to get CI passing. Notable: