This repository was archived by the owner on Apr 2, 2024. It is now read-only.
is-mobile helper #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandydoo Can you review this PR. |
sandydoo
suggested changes
Aug 7, 2019
|
@sandydoo Reverted the changes as you specified |
sandydoo
suggested changes
Aug 7, 2019
|
@sandydoo done |
sandydoo
suggested changes
Aug 8, 2019
README.md
Outdated
| @@ -51,7 +51,7 @@ It expects one argument to be passed as a param. | |||
| ``` | |||
|
|
|||
| ```handlebars | |||
| <div class="{{if (is-mobile 'android' 'is-android')}} {{if (is-mobile 'apple' 'is-apple')}}"> | |||
| <div class="{{if (is-mobile 'android') 'is-android')}} {{if (is-mobile 'apple') 'is-apple')}}"> | |||
There was a problem hiding this comment.
This still doesn't work. You still have the extra parentheses on the ends there.
Should be:
There was a problem hiding this comment.
My bad, sorry for multiple commits
|
Thanks, @Amerr! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is-mobilefunctionality in templates, without injecting as service.