Use lib instead of lib64 #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 106abec.
Thc change made to use CMAKE_INSTALL_LIBDIR is causing issues for the installations due to the removal of the SEACAS_LIBDIR which was used in the finding of libexodus.so for exodus.py. Using CMAKE_INSTALL_LIBDIR will not currently work for this as it points to lib64 instead of lib which is where libexodus.so is being installed. This leaves us with a few choices with the revert of this being the easiest option though likely not the option we want long term.
gsjaardema
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change made to use CMAKE_INSTALL_LIBDIR is causing issues for the
installations due to the removal of the SEACAS_LIBDIR which was used
in the finding of libexodus.so for exodus.py. Using CMAKE_INSTALL_LIBDIR
will not currently work for this as it points to lib64 instead of lib
which is where libexodus.so is being installed.
This leaves us with a few choices with the revert of this being the easiest
option though likely not the option we want long term.