move @@type properties to type representatives #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
suggested changes
Dec 23, 2016
| } | ||
|
|
||
| Either.prototype['@@type'] = 'sanctuary-def/Either'; |
There was a problem hiding this comment.
I guess prototype is not needed here?
| var MaybeTypeDict = { | ||
| 'fantasy-land/empty': function() { return Nothing; }, | ||
| 'fantasy-land/of': function(x) { return Just(x); } | ||
| function _Maybe(tag, value) { |
There was a problem hiding this comment.
btw would be nice if we move this types in FL as we have them in sanctuary, sanctuary-dev and i think in sanctuary-type-classes too 👯♂️
safareli
approved these changes
Dec 24, 2016
This was referenced Dec 24, 2016
davidchambers
force-pushed
the
dc-type
branch
2 times, most recently
from
f7e74cd to
f349350
Compare
davidchambers
force-pushed
the
dc-type
branch
from
f349350 to
b1d11c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request accompanies sanctuary-js/sanctuary-type-classes#22.