Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 [i2479] - RSolr error when updating an tenant settings #2480

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Mar 6, 2025

issue reported by + solution c/o George Leithner

Issue:

Error was caused by changes done in this PR (aka me -> oops! 🙈):

Steps to reproduce the behavior

In the admin console logged in as a superadmin, create a new account.
When it's complete, click edit account
check the "is public" box and save changes.

BEFORE

when creating an account then saving a change:

image

AFTER

when creating an account then saving a change:

image

Copy link

github-actions bot commented Mar 6, 2025

Test Results

    3 files  ±0      3 suites  ±0   18m 11s ⏱️ + 1m 7s
2 096 tests ±0  2 040 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 123 runs  ±0  2 065 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 3f8f604. ± Comparison against base commit b14e5de.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy f756bb30-7aff-4d5b-bb5a-e1cfcb262f07
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 9134739b-736d-4f88-88ff-442823cd89b5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read d33e0be6-1c05-4907-b465-ac6bbcb2a8fb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 0aa47d86-abc1-40fa-ae0e-6394b5ee021a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 6de24cdc-2760-4523-bc25-498d1aef1a31
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 0dc28a31-09b4-4d9d-a2b1-ef6963d2258e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 4bab1b87-6381-48a6-aa1f-e46755a7668a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update a078ae58-b8ac-4680-9eaa-a9b708eeb2f5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy ab3209cc-aad5-4ee2-916e-fc4a410c4a12
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5d2f55bf-2308-4fdb-a2e8-c1e9a02b976f
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 2e10b87f-398b-413b-bcce-71be06c1a135
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit ac5b78e0-76a0-4ab4-bf8d-230eca3f35da
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 467b6362-9ae7-468a-aac6-9171344c483a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 8d95e5c0-8ccb-45d4-aea7-f108e4c1f7c3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 6c11457a-4403-43ef-a8fa-8ff06163398c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit e3fa96f2-ab39-4f55-9caa-ecfe2598fa3f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 6b470b46-fd6a-4261-8d27-bc00bcb17fc9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 0f6c8756-46c6-4cf4-8f63-17d4bd1d1808
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 79a3057a-c07d-4090-9757-25f0e0b1790b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 45c5a442-c0c2-4203-bba8-bb8d9854509e
…

@ShanaLMoore ShanaLMoore merged commit a094ef9 into main Mar 6, 2025
9 of 10 checks passed
@ShanaLMoore ShanaLMoore deleted the i2479-rsolr-error-when-updating-tenant-settings branch March 6, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants