Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes deprecated derived and is_derived #2476

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

ShanaLMoore
Copy link
Collaborator

This code is from pre iiif print; it is no longer needed:

Issue:

ref

This code is from pre iiif print; it is no longer needed:

Issue:
- notch8/palni_palci_knapsack#277

ref
- notch8/palni-palci@687f361
@ShanaLMoore ShanaLMoore added the patch-ver for release notes label Feb 28, 2025
@ShanaLMoore ShanaLMoore changed the title removes derived and is_derived removes deprecated derived and is_derived Feb 28, 2025
@ShanaLMoore ShanaLMoore requested a review from laritakr February 28, 2025 23:08
laritakr
laritakr previously approved these changes Feb 28, 2025
Copy link

github-actions bot commented Feb 28, 2025

Test Results

    3 files  ±0      3 suites  ±0   18m 33s ⏱️ +46s
2 091 tests ±0  2 035 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 118 runs  ±0  2 060 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 5747020. ± Comparison against base commit f0a6ef7.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy a332a55f-0fda-42c1-a628-9fa0d33f3135
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit c35b4991-c118-476e-a066-1301b39216a1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read cb7b80dc-665a-4959-a894-c61683e67d9c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 1c006121-d7fb-4f4b-8c55-699fbd4402c7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 149831cd-a418-4f00-bc79-e40cd3f2f558
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit e7e48ef8-8fc9-413a-9160-422adad19aba
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8ccf22fc-5319-449d-8738-6b0eb8fec120
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 71f0140a-6af8-4f88-904f-123ea27e15dc
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 20482bdc-65da-433f-bc19-ae0c50342276
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 5ebcf2b6-6d78-41de-8fc1-14de518c0fd7
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy c0d848e4-8c66-41b5-a60c-fd9af96602a5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 96cce90c-82e8-41bc-a9c7-6761ffb2f262
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 7f1813a4-b1dd-4d41-b4b2-3f2f58492cc6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 6fd0f4a5-c115-40bc-9af6-f196846ca48c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3655d1eb-c09c-4309-a2d9-66f7310de5be
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f42a5c77-d8ed-4538-a7a6-08cfa9703f5d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 6e89b461-b0ec-4f06-b207-2b1d18d8a01a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update ee548ed4-9cbd-4793-9c45-39a23d1d9bf6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 89e312ba-ee93-4c37-8044-ee7cd4fc653e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit c103d313-0450-4233-9755-5675ec4994ee
…

♻️ This comment has been updated with latest results.

laritakr
laritakr previously approved these changes Mar 1, 2025
@ShanaLMoore ShanaLMoore merged commit 3e1e084 into main Mar 3, 2025
8 checks passed
@ShanaLMoore ShanaLMoore deleted the i277-remove-deprecated-code-is_derived branch March 3, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants